Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in prep for pydata-sphinx-theme update #1725

Conversation

kay-kim
Copy link
Contributor

@kay-kim kay-kim commented Oct 3, 2022

This PR should allow for the pydata-sphinx-theme update in #1696.

👉 Let me know if I should apply directly to that patch to that PR so that it'll build with the new version. Currently, will build against the old version.

Basically:

  • Explicitly mention our css file.
  • Include html_context for light/dark/auto mode.
  • Explicitly mention favicon.

Note: The docs-assets layout have been updated to address the generate_nav_html warning.

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-client-js ❌ Failed (Inspect) Oct 3, 2022 at 9:37PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eb446a:

Sandbox Source
solid-client-sandbox Configuration

@kay-kim kay-kim marked this pull request as ready for review October 3, 2022 21:39
@kay-kim kay-kim requested a review from a team as a code owner October 3, 2022 21:39
@kay-kim
Copy link
Contributor Author

kay-kim commented Oct 3, 2022

Closing this PR. Am applying the patch to the #1696 insteadl.

@kay-kim kay-kim closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant