fix #137, still requires unit test

inrupt · Aug 9, 2019 · d8102d1 · d8102d1
1 parent d665998
commit d8102d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/lib/api/http/HttpResponder.ts b/src/lib/api/http/HttpResponder.ts
@@ -10,6 +10,7 @@ export enum ResultType {
   CouldNotParse,
   AccessDenied,
   PreconditionFailed,
+  PreconditionRequired,
   NotModified,
   NotFound,
   QuotaExceeded,
@@ -62,6 +63,11 @@ const responses: Responses = {
     responseBody: 'Precondition failed',
     constrainedBy: 'conflict'
   },
+  [ResultType.PreconditionFailed]: {
+    responseStatus: 428,
+    responseBody: 'Precondition required',
+    constrainedBy: 'precondition-required'
+  },
   [ResultType.NotFound]: {
     responseStatus: 404,
     responseBody: 'Not found',

diff --git a/src/lib/operationHandlers/writeBlobHandler.ts b/src/lib/operationHandlers/writeBlobHandler.ts
@@ -23,7 +23,7 @@ export const writeBlobHandler = {
     debug('checking If-Match presence', ifMatchHeaderPresent, task.ifMatch(), task.ifNoneMatchStar(), task.ifMatchRequired, blobExists)
     if (blobExists || (task.ifMatchRequired && !ifMatchHeaderPresent)) {
       debug('attempt to overwrite existing resource')
-      throw new ErrorResult(ResultType.PreconditionFailed)
+      throw new ErrorResult(ResultType.PreconditionRequired)
     }
     const resultType = (blobExists ? ResultType.OkayWithoutBody : ResultType.Created)
     const contentType: string | undefined = task.contentType()