Avoid errors when using aliases in calendar invites #621
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the calendar ID (i.e. the primary email) doesn't exactly match the invitee's email, `gcalcli agenda --nodeclined` will throw an error. This change changes makes use of the 'self' property of the attendee to determine identity instead of comparing strings, thus enabling support for alias-based invitations. Now it's possible for firstname.lastname@domain.com to be invited as firstname@domain.com and still use `gcalcli agenda --nodeclined`. insanum#620
|
Hi @insanum! Would you mind merging it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the calendar ID (i.e. the primary email) doesn't exactly match the invitee's email,
gcalcli agenda --nodeclinedwill throw an error.This change changes makes use of the 'self' property of the attendee to determine identity instead of comparing strings, thus enabling support for alias-based invitations.
Now it's possible for firstname.lastname@domain.com to be invited as firstname@domain.com and still use
gcalcli agenda --nodeclined.#620