Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend --style scatter to tsview #1157

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 9, 2024

Description of proposed changes

This PR fixes the following errors (as found out by @falkamelung) introduced in #1146, and extends the --style scatter capability to tsview as well.

tsview.py S1_IW12_087_0529_0530_20180902_20240104_N19421_N19519_W154945_W154827.he5
open HDFEOS file: S1_IW12_087_0529_0530_20180902_20240104_N19421_N19519_W154945_W154827.he5
data   coverage in y/x: (0, 0, 474, 390)
subset coverage in y/x: (0, 0, 474, 390)
data   coverage in lat/lon: (-154.94537646484375, 19.518744537353516, -154.82687646484374, 19.421244537353516)
subset coverage in lat/lon: (-154.94537646484375, 19.518744537353516, -154.82687646484374, 19.421244537353516)
------------------------------------------------------------------------
reference point in y/x: (115, 314)
reference point in lat/lon: (19.489869537353517, -154.86675146484376)
estimate deformation model with the following assumed time functions:
    polynomial : 1
    periodic   : []
    stepDate   : []
    polyline   : []
    exp        : {}
    log        : {}
reading timeseries from file S1_IW12_087_0529_0530_20180902_20240104_N19421_N19519_W154945_W154827.he5
reference to pixel: (115, 314)
reference to date: 20210206
read HDFEOS contained mask dataset.
data    range: [-15.96868, 17.101936] cm
display range: [-14.569724, 14.711732] cm
create figure for map in size of [6.0, 6.7]
display data in transparency: 1.0
plot in geo-coordinate
Traceback (most recent call last):
  File "/Users/famelung/code/rsmas_insar/tools/miniconda3/bin/tsview.py", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/famelung/code/rsmas_insar/tools/MintPy/src/mintpy/cli/tsview.py", line 176, in main
    obj.plot()
  File "/Users/famelung/code/rsmas_insar/tools/MintPy/src/mintpy/tsview.py", line 715, in plot
    self.plot_init_image(img_data)
  File "/Users/famelung/code/rsmas_insar/tools/MintPy/src/mintpy/tsview.py", line 846, in plot_init_image
    self.img, self.cbar_img = view.plot_slice(self.ax_img, img_data, self.atr, self)[2:4]
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/famelung/code/rsmas_insar/tools/MintPy/src/mintpy/view.py", line 558, in plot_slice
    elif inps.style == 'image':
         ^^^^^^^^^^
AttributeError: 'timeseriesViewer' object has no attribute ‘style'

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz yunjunz requested a review from falkamelung March 9, 2024 16:41
@falkamelung
Copy link
Contributor

Looks good to me. But to be honest, I can't tell. I am not a valuable reviewer. I can report bugs, though

@falkamelung falkamelung closed this Mar 9, 2024
Copy link
Contributor

@falkamelung falkamelung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But to be honest. I can't tell. I am not (yet?) a valuable reviewer. I don't even find where to do the review. I can report bugs, though

@yunjunz yunjunz reopened this Mar 10, 2024
@yunjunz
Copy link
Member Author

yunjunz commented Mar 10, 2024

Thank you for the quick feedback and confirmation. That's fine Falk. I was able to reproduce the same error and could confirm it was fixed by this PR. I am gonna go ahead and merge it.

@yunjunz yunjunz merged commit 7ac3455 into insarlab:main Mar 10, 2024
10 checks passed
@yunjunz yunjunz deleted the tsview_scatter branch March 10, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants