Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for coord.lalo2yx() when lat/lon have diff sizes #1160

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 18, 2024

Description of proposed changes

  • objects.coord.coordinate:

  • subset.subset_input_dict2box(): use None as input to convert one type of coord only.

  • utils.arg_utils.add_subset_argument(): remove the unused option name alias (--suby/x/lat/lon), as they are not very readable and not frequently used.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ objects.coord.coordinate:
   - _clean_coord(): 1) take two arg instead of one, and ensure the two coords have the same size; 2) support None
   - lalo2yx/yx2lalo(): support None as inputs

+ subset.subset_input_dict2box(): use None as input to convert one type of coord only.

+ utils.arg_utils.add_subset_argument(): remove the unused option name alias (--suby/x/lat/lon), as they are not very readable and not frequently used.
@yunjunz yunjunz merged commit 0c45019 into insarlab:main Mar 18, 2024
7 checks passed
@yunjunz yunjunz deleted the coord branch March 18, 2024 06:06
ehavazli pushed a commit to ehavazli/MintPy that referenced this pull request Mar 19, 2024
)

+ `objects.coord.coordinate`:
   - `_clean_coord()`: 1) take two arg instead of one, and ensure the two coords have the same size; 2) support `None` as input
   - `lalo2yx/yx2lalo()`: support `None` as inputs

+ `subset.subset_input_dict2box()`: use `None` as input to convert one type of coord only.

+ `utils.arg_utils.add_subset_argument()`: remove the unused option name alias (`--suby/x/lat/lon`), as they are not very readable and not frequently used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant