Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support LAT/LON_REF1/2/3/4 in UTM coordinates #1161

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 18, 2024

Description of proposed changes

  • docs/api/attributes.md: ensure all *LAT/LON* attributes represents both latitude/northing and longitude/easting in degrees/meters

  • utils.utils0.utm2latlon/latlon2utm(): support list/tuple input types

  • prep_hyp3:

    • do not convert UTM to lat/lon for LAT/LON_REF1/2/3/4
    • add HDF-EOS5 metadata (beam_mode and unwrap_method) from the HyP3 metadata file
  • save_hdfeos5.metadata_mintpy2unavco(): convert UTM to lat/lon while calculating the scene_footprint

  • tests/configs/RidgecrestSenDT71.txt: turn ON mintpy.save.hdfEos5 option

  • .circleci/config.yml: add RidgecrestSenDT71 (HyP3) to the routine integration testing.

  • tropo_pyaps3.get_bounding_box(): convert UTM to lat/lon if using LAT/LON_REF1/2/3/4 in UTM coordinates.

Reminders

  • Fix metadata inconsistency for UTM coordinates #1145
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ docs/api/attributes.md: ensure all LAT/LON attributes represents both latitude/northing and longitude/easting in degrees/meters

+ utils.utils0.utm2latlon/latlon2utm(): support list/tuple input types

+ prep_hyp3:
   - do not convert UTM to lat/lon for LAT/LON_REF1/2/3/4
   - add HDF-EOS5 metadata (`beam_mode` and `unwrap_method`) from the HyP3 metadata file

+ save_hdfeos5.metadata_mintpy2unavco(): convert UTM to lat/lon while calculating the scene_footprint and subset filename suffix

+ tests/configs/RidgecrestSenDT71: turn ON mintpy.save.hdfEos5 and mintpy.save.hdfEos5.subset options

+ .circleci/config.yml: add RidgecrestSenDT71 (HyP3) to the routine integration test

+ tropo_pyaps3.get_bounding_box(): convert UTM to lat/lon
@yunjunz yunjunz merged commit b0336c1 into insarlab:main Mar 18, 2024
7 checks passed
@yunjunz yunjunz deleted the lat_lon_ref branch March 18, 2024 11:27
ehavazli pushed a commit to ehavazli/MintPy that referenced this pull request Mar 19, 2024
This commit adds the support of UTM coordinates for the `LAT/LON_REF1/2/3/4` metadata in all related docs/code, in addition to the existing support for the Y/X_FIRST/STEP/UNIT and REF_LAT/LON, UTM_ZONE and EPSG. Thus, all mintpy metadata now supports UTM coordinates.

+ docs/api/attributes.md: ensure all LAT/LON attributes represent both latitude/northing and longitude/easting in degrees/meters

+ utils.utils0.utm2latlon/latlon2utm(): support list/tuple input types

+ prep_hyp3:
   - do not convert UTM to lat/lon for LAT/LON_REF1/2/3/4
   - add HDF-EOS5 metadata (`beam_mode` and `unwrap_method`) from the HyP3 metadata file

+ save_hdfeos5.metadata_mintpy2unavco(): convert UTM to lat/lon while calculating the scene_footprint and subset filename suffix

+ tests/configs/RidgecrestSenDT71: turn ON mintpy.save.hdfEos5 and mintpy.save.hdfEos5.subset options

+ .circleci/config.yml: add RidgecrestSenDT71 (HyP3) to the routine integration test

+ tropo_pyaps3.get_bounding_box(): convert UTM to lat/lon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata inconsistency for UTM coordinates
1 participant