Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tropo_pyaps3: use larger SNWE local files if available #1164

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 19, 2024

Description of proposed changes

This PR searches existing local grib files with larger SNWE extent than the input required SWNE, uses that if more local files exist, thus, could avoid re-downloading from ECMWF as much as possible.

  • add get_larger_snwe_in_local_files() to find and locate the local files with larger SNWE extent than the input original ones, and use that if more local files exist.

  • move many tiny functions as sub-functions inside the main ones, to improve the code readability (simpler code logic flow)

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI and local test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ move many tiny functions as sub-functions inside the main ones, to improve the code readability (simpler code logic flow)

+ add `get_larger_snwe_in_local_files()` to find and locate the local files with larger SNWE extent than the input original ones, and use that if more local files exists, to avoid re-downloading from ECMWF as much as possible
@yunjunz yunjunz merged commit 39762c8 into insarlab:main Mar 19, 2024
7 checks passed
@yunjunz yunjunz deleted the dload_era5 branch March 19, 2024 08:01
ehavazli pushed a commit to ehavazli/MintPy that referenced this pull request Mar 19, 2024
This PR searches existing local grib files with larger SNWE extent than the input required SWNE, uses that if more local files exist, thus, could avoid re-downloading from ECMWF as much as possible.

+ add `get_larger_snwe_in_local_files()` to find and locate the local files with larger SNWE extent than the input original ones, and use that if more local files exist.

+ move many tiny functions as sub-functions inside the main ones, to improve the code readability (simpler code logic flow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant