Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for view.py numInvIfgram.py for hyp3 products #1187

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Apr 25, 2024

Description of proposed changes

  • ifgram_inversion: ignore the NO_DATA_VALUE metadata from the hyp3 ifgram stack file, while creating the # of inverted ifgram file, because 1) the zero value is valid (not no-data-value), and 2) to avoid the strange plotting error from matplotlib. The detailed reason seems to be within matplotlib, not within mintpy code itself.

  • tests/configs/RidgecrestSenDT71: turn back ON the plotting during testing.

Reminders

  • Fix view.py numInvIfgram.h5 error for RidgecrestSenDT71 #1185
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI and local tests (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ ifgram_inversion: ignore the NO_DATA_VALUE metadata from the hyp3 ifgram stack file, while creating the # of inverted ifgram file, because 1) the zero value is valid (not no-data-value), and 2) to avoid the strange plotting error from matplotlib. The detailed reason seems to be within matplotlib, not within mintpy code itself.

+ tests/configs/RidgecrestSenDT71: turn back ON the plotting during testing.
@yunjunz yunjunz merged commit 4d34412 into insarlab:main Apr 25, 2024
7 checks passed
@yunjunz yunjunz deleted the view-bugfix branch April 25, 2024 13:13
@forrestfwilliams
Copy link
Collaborator

Thanks for this @yunjunz!

@yunjunz
Copy link
Member Author

yunjunz commented Apr 25, 2024

I think the code is now for a new release, will try to do it in the coming few days. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view.py numInvIfgram.h5 error for RidgecrestSenDT71
2 participants