Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA standard products #76

Merged
merged 4 commits into from
Jun 6, 2019
Merged

ARIA standard products #76

merged 4 commits into from
Jun 6, 2019

Conversation

hfattahi
Copy link
Collaborator

@hfattahi hfattahi commented Jun 6, 2019

This PR adds a stand-alone script "prep_aria.py" which creates interferogram and geometry HDF5 files from ARIA standard products. prep_aria.py is not integrated to load_data.py in mintpy. One needs to first run ARIA-tools (will be available soon) to create required files which perp_aria.py works with.
A minor bug is also fixed in which checking lookup files is skipped for geocoded data.

@hfattahi hfattahi requested a review from yunjunz June 6, 2019 04:56
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Thank you Heresh!

@yunjunz yunjunz merged commit 968fb6e into insarlab:master Jun 6, 2019
@hfattahi
Copy link
Collaborator Author

@ehavazli I think in the ARIA products, the refernce date is always the second date and the following date is the first date. I think MintPy expects the opposite. I therefore swapped the dates within prep_aria.py and multiplied baseline by -1. Maybe we should do the same for phase?

@ehavazli
Copy link
Contributor

@hfattahi I believe the products have the right phase information but I am not sure how mintpy treats it. I have an example area to check and I can share the result with you.

@hfattahi
Copy link
Collaborator Author

It's not about right or wrong phase information. It's about the choice of "sign". In Mintpy time-series outputs, subsidence comes out as negative values and uplift as positive. If you have a case study that you know what ground displacement expect, then we can fix the sign in prep_aria.py if a fix is needed.

@ehavazli
Copy link
Contributor

right as in the proper sign however the results that came out over Norfolk is in the wrong direction, therefore there should be a fix. The problem I had with this is there are a few spots in my track which seem to have the correct direction of deformation but I just confirmed with David's intern about Norfolk so the phase should also be multiplied with -1.

@hfattahi
Copy link
Collaborator Author

@ehavazli Thanks Emre. I just issued a PR which should fix the sign. BTW, I think we should open issues for these kind of discussions instead of commenting on closed PRs. Maybe next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants