Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unmask ref pixel in ts2vel and tsview #842

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Conversation

bbuzz31
Copy link
Contributor

@bbuzz31 bbuzz31 commented Sep 4, 2022

when the timeseriesResidual.h5 is created with timeseries2velocity.py --save-res, the reference pixel time series is overwritten with np.nan.

Then, when plotting (e.g., tsview.py) the whole dataset is masked out because it gets referenced back to the nan time series. This fix just preserves the 0 vector timeseries at the reference point.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz yunjunz self-requested a review September 5, 2022 18:36
@yunjunz yunjunz changed the title unmask ref pixel unmask ref pixel in ts2vel and tsview Sep 5, 2022
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @bbuzz31.

@yunjunz yunjunz merged commit 4a0f2c5 into insarlab:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants