Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writefile.write: force BANDS to 2 for .unw file #871

Merged
merged 1 commit into from
Oct 16, 2022
Merged

writefile.write: force BANDS to 2 for .unw file #871

merged 1 commit into from
Oct 16, 2022

Conversation

bjmarfito
Copy link
Contributor

@bjmarfito bjmarfito commented Oct 16, 2022 •
edited by yunjunz
Loading

Description of proposed changes

  • Added a line to writefile.py so that MintPy can recognise the no. of bands after deramping the .unw file.

Reminders

  • Fix update attribute error when running remove_ramp.py on binary data file #861
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz yunjunz changed the title Changes to writefile.py to fix the issue related to the number of band for .unw file after deramping writefile.write: fix BANDS to 2 for .unw file Oct 16, 2022
@yunjunz yunjunz changed the title writefile.write: fix BANDS to 2 for .unw file writefile.write: force BANDS to 2 for .unw file Oct 16, 2022
yunjunz
yunjunz approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @bjmarfito.

@yunjunz yunjunz merged commit 868c27f into main Oct 16, 2022
@yunjunz yunjunz deleted the bjmarfito-patch-1 branch October 16, 2022 17:52
yuankailiu pushed a commit to yuankailiu/MintPy that referenced this pull request Oct 17, 2022
@bjmarfito @yuankailiu
writefile.write: force BANDS to 2 for .unw file (insarlab#871)
2a2d4a1 
to ensure the consistency between output metadata and data with the 2-band format, because the input *.unw file may have only 1-band, as produced by `isce2/alosStack`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update attribute error when running remove_ramp.py on binary data file
2 participants
@bjmarfito @yunjunz