Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pre-commit to dependency and contributing guideline #873

Merged
merged 5 commits into from
Oct 19, 2022
Merged

add pre-commit to dependency and contributing guideline #873

merged 5 commits into from
Oct 19, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 19, 2022 •
edited
Loading

Description of proposed changes

  • add pre-commit to the following dependency files, so that it will be installed automatically in the development version.

    • docs/environment.yml
    • requirements.txt
    • setup.py

  • docs/CONTRIBUTING: add note to install pre-commit

  • github PR template: add selection box for pre-commit check.

  • readfile.read_template: bugfix for skip_chars arg (fix mintpy.geocode.SNWE = [] typo induced error #872)

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz
ptime.read_date_txt(): ignore invalid/empty lines
7bc5b19
@yunjunz
read_template: bugfix for skip_chars arg
8b27b77
@yunjunz
deps: add pre-commit
3e56eed 
+ add `pre-commit` to the following dependency files, so that it will be installed automatically in the development version.
   - docs/environment.yml
   - requirements.txt
   - setup.py

+ docs/CONTRIBUTING: add note to install `pre-commit`

+ github PR template: add selection box for pre-commit check.
@yunjunz yunjunz changed the title Deps add pre-commit to dependency and contributing guideline Oct 19, 2022
@yuankailiu
Update CONTRIBUTING.md
fd30ecf 
we need to run `pre-commit sample-config` to have a basic config file before running `pre-commit install`.
yuankailiu
yuankailiu approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@yuankailiu yuankailiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and it looks fine to me !

@yuankailiu yuankailiu merged commit 4756732 into insarlab:main Oct 19, 2022
@yunjunz yunjunz deleted the deps branch October 19, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuankailiu yuankailiu Awaiting requested review from yuankailiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mintpy.geocode.SNWE = [] typo induced error
2 participants
@yunjunz @yuankailiu