Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_roipac: support non-velocity dataset from the velocity file #874

Merged
merged 7 commits into from
Oct 23, 2022

Conversation

bjmarfito
Copy link
Contributor

@bjmarfito bjmarfito commented Oct 21, 2022

Description of proposed changes

  • Ability to extract a specific dataset from a velocity file and save it in ROIPAC format.
  • Removed behavior to make datasets into displacement values with the exception of the velocity dataset

Reminders

  • Pass Codacy code review (green)
  • Pass Pre-commit check (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@bjmarfito bjmarfito changed the title Extract a specific dataset in a velocity file using save_roipac.py Extract a specific dataset in a velocity file and commented out codes related to converting velocity to displacement using save_roipac.py Oct 21, 2022
mintpy/save_roipac.py Outdated Show resolved Hide resolved
@bjmarfito bjmarfito changed the title Extract a specific dataset in a velocity file and commented out codes related to converting velocity to displacement using save_roipac.py Extract a specific dataset in a velocity file in save_roipac.py Oct 22, 2022
@yunjunz yunjunz changed the title Extract a specific dataset in a velocity file in save_roipac.py save_roipac: support non-velocity dataset from the velocity file Oct 22, 2022
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me now. Thank you @bjmarfito for contributing!

@yunjunz yunjunz merged commit 4275a94 into main Oct 23, 2022
@yunjunz yunjunz deleted the bjmarfito-patch-1-1 branch October 23, 2022 03:58
@bjmarfito
Copy link
Contributor Author

You're welcome and thank you @yunjunz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants