-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to src
layout
#903
switch to src
layout
#903
Conversation
+ move "mintpy" to "src/mintpy" + setup.py: update "version" and "packages" settings for the new src layout
+ move/rename "mintpy/data/input_files" to "docs/templates" - setup.py: remove "data/input_files" from the package data section + update links for the new "src" layout in: - docs/api/attributes.md - docs/google_earth.md - docs/hdfeos5.md - docs/README.md - mkdocs.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I haven't fully tested the pip
build/install yet but will do so in the morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
(mapping) staniewi:MintPy$ ls /Users/staniewi/miniconda3/envs/mapping/lib/python3.10/site-packages/__editabl*mint*
/Users/staniewi/miniconda3/envs/mapping/lib/python3.10/site-packages/__editable__.mintpy-1.4.1.post43.pth
(mapping) staniewi:MintPy$ cat /Users/staniewi/miniconda3/envs/mapping/lib/python3.10/site-packages/__editabl*mint*
/Users/staniewi/repos/MintPy/src
(mapping) staniewi:MintPy$ cd
(mapping) staniewi:~$ mkdir -p mintpy
(mapping) staniewi:~$ python
Python 3.10.5 | packaged by conda-forge | (main, Jun 14 2022, 07:07:06) [Clang 13.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mintpy
>>> mintpy.__file__
'/Users/staniewi/repos/MintPy/src/mintpy/__init__.py'
+ installation: revert back $MINTPY_HOME to the path of "MintPy" folder, from "MintPy/src". + update usage of MINTPY_HOME for the "src" layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and is working the way I'd expect.
Description of proposed changes
switch
mintpy
to the standardsrc/mintpy
layout for the source code, to fixpip -e
installedmintpy.__file__ = None
when there is amintpy
folder in current dir #882 as suggested by @scottstanie.move and rename
mintpy/data/input_files
todocs/templates
update links and paths for 1) the
src
layout, 2) the renamedtemplate
dir and 3)$MINTPY_HOME
usage:update
setup.py
:src
layoutdata/input_files
from thepackage_data
sectionversion
: use.postX
style for the commits after release, to be consistent withpip
conventionReminders