Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plate_motion: add --plate option to use built-in tables #906

Merged
merged 2 commits into from
Nov 17, 2022
Merged

plate_motion: add --plate option to use built-in tables #906

merged 2 commits into from
Nov 17, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 14, 2022 •
edited
Loading

Description of proposed changes

  • plate_motion: add --plate option to use built-in tables for easy usage

  • move add_attribute.py to the legacy dir

Reminders

  • Pass Codacy code review (green)
  • Pass Pre-commit check (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz
move add_attribute.py to legacy dir
2a5bb67 
move `mintpy/add_attribute.py` to the `mintpy/legacy` directory because:

1. it's rarely used (it was designed as a quick hack to fix unexpected metadata problems)
2. it does not have the argparse usage to be included in the "mintpy/cli" sub-module, making it inconvenient to maintain
3. its functionality can be covered in Python using `mintpy.utils.utils.add_attribute()` API and in command line by adding extra metadata in the custom template file during data loading process.
@yunjunz
plate_motion: add --plate option to use built-in tables
ebf4ca9 
add --plate option to grab the built-in rotation parameters from ITRF2014-PMM (Altamimi et al., 2017), for easy usage.
yuankailiu
yuankailiu approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@yuankailiu yuankailiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These changes look very nice to me.

@yuankailiu yuankailiu merged commit 7181dec into insarlab:main Nov 17, 2022
@yunjunz yunjunz deleted the pmm branch November 17, 2022 00:57
@yunjunz yunjunz mentioned this pull request Nov 23, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuankailiu yuankailiu yuankailiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yunjunz @yuankailiu