Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter probe errors from the events displayed at service creation #814

Closed
avouacr opened this issue May 31, 2024 · 4 comments
Closed

Filter probe errors from the events displayed at service creation #814

avouacr opened this issue May 31, 2024 · 4 comments
Assignees

Comments

@avouacr
Copy link
Member

avouacr commented May 31, 2024

Hi @garronej,

The display of events when launching a service from the catalog is a pretty cool feature, but unfortunately it also displays irrelevant errors, particularly those from probes' healthchecks that almost systematically happen during startup. I think we should filter out these specific events, as they can mislead users into believing there is some sort of error with their service creation although it actually creates itself as expected.

image

@avouacr avouacr changed the title Filter probe errors from events at service creation Filter probe errors from the events displayed at service creation May 31, 2024
@fcomte
Copy link
Contributor

fcomte commented May 31, 2024

maybe we can only add an expand button to see all the details (events) when a service is starting.... most users don't want to see this meaningless event.

what do you think @avouacr ?

@avouacr
Copy link
Member Author

avouacr commented May 31, 2024

Yes that's probably even better in terms of UX. In that case we should also put the red progress bar within the expandable component, otherwise it visually clashes a bit with the animation on the "open the service" button before it appears.

@fcomte
Copy link
Contributor

fcomte commented May 31, 2024

yes i think also : most of the time all of this take 5 seconds.

@garronej what do you think , can we hide that by default and let user expand to see this noisy details ?

@garronej
Copy link
Contributor

garronej commented Jun 1, 2024

I filtered out probe failed from the open modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants