Remove contrast_target_prefixes from contrastive step functions #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
contrast_target_prefixes
argument from all contrastive functions and implements default right-side alignment of contrastive sequences. This allows a more intuitive usage of contrastive step functions that 1) doesn't require splitting manually the contrastive target prefix and 2) works out of the box for decoder-only LMs:Example before:
After: