Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL to arXiv #259

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix URL to arXiv #259

merged 1 commit into from
Mar 12, 2024

Conversation

bbjoverbeek
Copy link
Contributor

Description

The URL was missing a digit, resulting in a link to an unrelated paper.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've successfully run the style checks using make fix-style.
  • I've written tests for all new methods and classes that I created and successfully ran make test.
  • I've written the docstring in Google format for all the methods and classes that I used.

@bbjoverbeek
Fix URL to arXiv
14ebfc4 
The URL was missing a digit, resulting in a link to an unrelated paper.
gsarti
gsarti approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@gsarti gsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@gsarti gsarti merged commit 70be7cf into inseq-team:main Mar 12, 2024
3 checks passed
gsarti added a commit to xuan25/inseq that referenced this pull request Apr 4, 2024
@gsarti
Merge remote-tracking branch 'origin' into feature/reagent
498132f 
* origin:
  Fix CTI on first token when whitespace
  Updated model config with Cohere and StarCoder2 (transformers v4.39)
  Fix attribute-context --help
  Strip prepended whitespace in
  Fix attribute-context with non-contrastive attribution
  Fix `IndexError` for dec-only models in `attribute-context`
  Fix  prefixed generation for mismatching tokenization
  Fix URL to arXiv (inseq-team#259)
  Fix install CI
  Various fixes to `attribute-context` (inseq-team#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsarti gsarti gsarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbjoverbeek @gsarti