Flutter 1.20.0 compatibility and improved test parsing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add support for Flutter 1.20.0 which emits empty lines and debug events * parse JSON events based on their type which is documented here: https://github.com/dart-lang/test/blob/master/pkgs/test/doc/json_reporter.md * restore Java 8 compatibility by removing `Path.of()` usage * use Scanner to read lines from file or String which should handle line endings correctly * do not report hidden tests, those are generated for setUp/tearDown functions - this previously resulted in way to many reported test cases * correctly determine the test duration, the outpout does not contain the duration but a start time and end time for each testID
|
@stephanecodes Could you review this please and see if that also solves your nullpointer problem. I am using this together with your change for the analysis file. |
|
Yes you did, I used your commit initially but I needed more changes. |
|
@kuhnroyal, @stephanecodes thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for Flutter 1.20.0 which emits empty lines and debug events
parse JSON events based on their type which is documented here: https://github.com/dart-lang/test/blob/master/pkgs/test/doc/json_reporter.md
restore Java 8 compatibility by removing
Path.of()usageuse Scanner to read lines from file or String which should handle line endings correctly
do not report hidden tests, those are generated for setUp/tearDown functions - this previously resulted in way to many reported test cases
correctly determine the test duration, the outpout does not contain the duration but a start time and end time for each testID
add maven wrapper to ease development