Adopt xcconfig, improve development experience for external contributors #673
+138
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenhumphreys
approved these changes
May 29, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges xcconfig adoption changes from #669 and makes the following changes:
OpenSource.xcconfigfile that's used for theWWDCscheme in bothDebug, andReleaseconfigurations (i.e. the scheme without iCloud support)bootstrap.shscript (or just theteamid.shscript) will ask for the team ID and generate theTeamID.xcconfigfile automaticallyThis way folks can pull the repo and get up and running quickly without creating spurious file changes that get picked up by source control due to setting code signing things manually in Xcode's UI.