Adopt Calendar write-only permission in macOS Sonoma #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,3 +137,107 @@ extension Storage { | |||
| setFavorite(!session.isFavorite, onSessionsWithIDs: [session.identifier]) | |||
| } | |||
| } | |||
|
|
|||
| // MARK: - Calendar Integration | |||
There was a problem hiding this comment.
Separate file? We have lots of AppCoordinator+'s already :)
allenhumphreys
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all we do is write to the calendar, we don't need full access.
There's a compile-time check so that the app keeps building just fine in Xcode 14. I wanted something like
#if __MAC_OS_X_VERSION_MAX_ALLOWEDin Swift, but apparently the only way to do a compile-time check for SDK is by using the#compilerdirective. If you know of a better solution let me know.