Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symmetric-padding support #830

Closed
pranavsrihari123 opened this issue Aug 7, 2024 · 5 comments · Fixed by #832
Closed

symmetric-padding support #830

pranavsrihari123 opened this issue Aug 7, 2024 · 5 comments · Fixed by #832
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pranavsrihari123
Copy link

I believe I made the necessary changes in the savant codebase to include symmetric-padding support, but I get this error:
Screen Shot 2024-08-06 at 5 19 48 PM

I believe omegaconf is not recognizing the changes? Any guidance on how to include symmetric-padding support?

@bwsw
Copy link
Contributor

bwsw commented Aug 7, 2024

You are right that there is no key 'symmetric_padding'. So far, you can use it only when you pass it with Nvinfer config directly, but not with YAML.

Samples of how to do that are here: https://github.com/insight-platform/Savant/tree/develop/samples/nvidia_car_classification/flavors

However, we will implement the parameter shortly. If you like you can track the issue and see when it is closed in a couple of days.

@bwsw bwsw added the enhancement New feature or request label Aug 7, 2024
@bwsw
Copy link
Contributor

bwsw commented Aug 7, 2024

@placccebo you can take a look here on how to do that: #816

There is a parameter function in the codebase for 'bool' which supports all True/False, Yes/No, Y/N, etc.

You must implement it in the same scope as input.maintain_aspect_ratio. Use your identity demo to check that the function is implemented correctly (you can update your identity to demonstrate both parameters).

@bwsw bwsw added this to the 0.4.1 milestone Aug 7, 2024
@placccebo placccebo linked a pull request Aug 7, 2024 that will close this issue
@bwsw
Copy link
Contributor

bwsw commented Aug 7, 2024

@pranavsrihari123 hi. The feature is merged.

A sample of the use can be found here: https://github.com/insight-platform/Savant/tree/develop/samples/bypass_model

Please wait until the job to complete: https://github.com/insight-platform/Savant/actions/runs/10283152157

After that, pull updated containers.

@bwsw
Copy link
Contributor

bwsw commented Aug 7, 2024

@pranavsrihari123
Copy link
Author

Excellent, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants