Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

148 distinguish between planned and actual arm in Chevron tlg-functions #156

Merged
merged 9 commits into from
Mar 25, 2022

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Mar 17, 2022

close #148

The arguments of the tlgs functions have been updated to reflect the selection of the planned or actual arm.
Thank you for the review.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/aet01.R                            142     142  0.00%    42-335
R/aet02.R                            163     163  0.00%    55-418
R/aet03.R                             61      61  0.00%    44-145
R/aet04.R                             81      81  0.00%    48-166
R/assertions.R                        23      23  0.00%    22-47
R/assertthat.R                         1       1  0.00%    3
R/cmt01a.R                           132     132  0.00%    52-376
R/cmt02_pt.R                          29      29  0.00%    36-92
R/dm_explicit_na.R                    44      44  0.00%    48-129
R/dmt01.R                             20      20  0.00%    48-112
R/dst01.R                            212     212  0.00%    5-551
R/dtht01.R                            69      69  0.00%    49-180
R/egt01.R                             39      39  0.00%    45-122
R/egt02.R                             44      44  0.00%    44-196
R/ext01.R                             41      41  0.00%    40-176
R/gen_args.R                           1       1  0.00%    18
R/lbt01.R                             34      34  0.00%    43-111
R/mht01.R                             52      52  0.00%    41-125
R/sample_study_object.R               14      14  0.00%    14-35
R/standard_data_preprocessing.R      220     220  0.00%    43-550
R/utils.R                            134     134  0.00%    16-376
R/vst01.R                             40      40  0.00%    46-125
R/vst02.R                             44      44  0.00%    44-195
TOTAL                               1640    1640  0.00%

Results for commit: c5adbac10f42bbe629ab9750c885be05696ce73b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@BFalquet BFalquet requested a review from barnett11 March 17, 2022 16:34
R/aet01.R Outdated Show resolved Hide resolved
R/aet01.R Outdated Show resolved Hide resolved
R/aet01.R Outdated Show resolved Hide resolved
R/aet01.R Outdated Show resolved Hide resolved
BFalquet and others added 2 commits March 21, 2022 10:05
Tim's suggestion

Co-authored-by: barnett11 <87320028+barnett11@users.noreply.github.com>
@barnett11
Copy link
Contributor

Thanks @BFalquet .
@wangh107 - do you see any concerns labelling the study object $actarm ? The planned arm is fine ('$planarm') , but obviously ACTARM is a formal ADSL variable name so could it cause confusion? Maybe $actualarm instead?

@wangh107
Copy link
Contributor

Thanks @BFalquet . @wangh107 - do you see any concerns labelling the study object $actarm ? The planned arm is fine ('$planarm') , but obviously ACTARM is a formal ADSL variable name so could it cause confusion? Maybe $actualarm instead?

sounds good. Use actualarm to avoid confusion.

@BFalquet BFalquet requested a review from barnett11 March 22, 2022 18:30
@BFalquet BFalquet merged commit 68a7d09 into main Mar 25, 2022
@BFalquet BFalquet deleted the 148_distinguish-between-planned-and-actual@main branch March 25, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distinguish between planned and actual arm in Chevron tlg-functions
3 participants