304 remove .study object #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this really simplifies our development and make the user understand it better. I fully agree that we should do like this. @crazycatandy what do you think? |
Closed
added 2 commits
November 2, 2022 15:51
clarkliming
reviewed
Nov 2, 2022
R/dst01.R
Outdated
| check_dst01_1_args <- function(reason, status, status_treatment) { | ||
| if (!missing(status)) { | ||
| stopifnot(status == "EOSSTT" || grepl("^EOP[[:digit:]]{2}STT$", status)) | ||
| check_dst01_1_args <- function(reason, status_var, status_treatment_var) { |
There was a problem hiding this comment.
what are these check for? I mean, if we are using the default ones, we are sure about the template used;if we there are arguments to specify these variables, what is the point of checking it again?anyway it is specified by user
There was a problem hiding this comment.
agreed, i was thinking of removing it when we get rid of the layout but i'll eliminate it now
There was a problem hiding this comment.
custom checks have been removed
There was a problem hiding this comment.
ok, I think we can keep focused on the removing of study object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#304
close #304
-removes the study object
thank you for the review