Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix note #319

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix note #319

merged 1 commit into from
Nov 14, 2022

Conversation

duanx9
Copy link
Contributor

@duanx9 duanx9 commented Nov 11, 2022 •
edited
Loading

close #289

Moved dm_unite() to dunlin

ref old discussions #303

@duanx9 duanx9 self-assigned this Nov 11, 2022
@duanx9 duanx9 marked this pull request as ready for review November 11, 2022 07:06
@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    9 suites   19s ⏱️
27 tests 25 ✔️   2 💤 0 ❌
72 runs  51 ✔️ 21 💤 0 ❌

Results for commit cb4de27.

clarkliming
clarkliming approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@duanx9 duanx9 merged commit b4b9264 into main Nov 14, 2022
@duanx9 duanx9 deleted the 289_fix_note@main branch November 14, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkliming clarkliming clarkliming approved these changes

Assignees

@duanx9 duanx9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix note
2 participants
@duanx9 @clarkliming