Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NOTE in aet05_all #554

Merged
merged 16 commits into from
Jun 27, 2023
Merged

fix NOTE in aet05_all #554

merged 16 commits into from
Jun 27, 2023

Conversation

duanx9
Copy link
Contributor

@duanx9 duanx9 commented Jun 27, 2023

* checking R code for possible problems ... NOTE
aet05_all_pre: no visible binding for global variable ‘USUBJID’
aet05_all_pre: no visible binding for global variable ‘AVAL’
Undefined global functions or variables:
  AVAL USUBJID

@duanx9 duanx9 self-assigned this Jun 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Unit Tests Summary

    1 files    48 suites   3m 23s ⏱️
209 tests 156 ✔️   53 💤 0
427 runs  299 ✔️ 128 💤 0

Results for commit 0754c75.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

🧪 $Test coverage: 97.89%$

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------
R/ael01_nollt.R                 17       1  94.12%   61
R/aet01_aesi.R                 147       1  99.32%   209
R/aet01.R                       92       1  98.91%   156
R/aet02.R                       57       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       36       1  97.22%   101
R/aet10.R                       42       0  100.00%
R/assertions.R                  99       6  93.94%   88-93
R/cfbt01.R                      90       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         18       0  100.00%
R/chevron_tlg-S4methods.R      103       0  100.00%
R/cmt01a.R                      76       0  100.00%
R/coxt02.R                      40       1  97.50%   114
R/dmt01.R                       26       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   48, 52-56
R/egt02.R                       36       0  100.00%
R/egt03.R                       61       1  98.36%   127
R/egt05_qtcat.R                 63       0  100.00%
R/ext01.R                       46       4  91.30%   110-111, 115-116
R/fstg01.R                      42       1  97.62%   95
R/kmg01.R                       28       1  96.43%   69
R/lbt04.R                       69       0  100.00%
R/lbt05.R                       66       5  92.42%   125-130
R/lbt06.R                       63       3  95.24%   132-135
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       57       0  100.00%
R/mht01.R                       71       0  100.00%
R/mng01.R                      113       1  99.12%   128
R/pdt01.R                       59       0  100.00%
R/pdt02.R                       66       0  100.00%
R/rmpt01.R                      62      11  82.26%   88-97, 140
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              223       7  96.86%   41, 98, 210, 298-301
R/standard_rules.R              11       0  100.00%
R/ttet01.R                     126       3  97.62%   226-229
R/utils.R                       50       0  100.00%
R/vst02.R                       46       1  97.83%   106
TOTAL                         2752      58  97.89%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9e376ed43d430f9e9f5457db0e6a5f848e7929d4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@duanx9 duanx9 requested a review from clarkliming June 27, 2023 05:06
@clarkliming
Copy link
Contributor

unrelated but very minor: please consider also update the minimum version of tern

tern (>= 0.8.2),

@duanx9
Copy link
Contributor Author

duanx9 commented Jun 27, 2023

unrelated but very minor: please consider also update the minimum version of tern

tern (>= 0.8.2),

how about >=0.8.3.9001?

@clarkliming
Copy link
Contributor

unrelated but very minor: please consider also update the minimum version of tern

tern (>= 0.8.2),

how about >=0.8.3.9001?

no, use released version (don't rely on development versions)

Copy link
Contributor

@clarkliming clarkliming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@duanx9 duanx9 merged commit e900de2 into main Jun 27, 2023
24 checks passed
@duanx9 duanx9 deleted the 379_aet05@main branch June 27, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants