Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

29 AET02 UAT feedback #64

Merged
merged 24 commits into from
Oct 8, 2021
Merged

29 AET02 UAT feedback #64

merged 24 commits into from
Oct 8, 2021

Conversation

BFalquet
Copy link
Contributor

close #29

  • Title line has been repaired.
  • Introduce blank line separators between SOC.
  • For now the documentation of the different functions is kept separated.
  • Null report function will be prepared separately.

Thank you for the review

@barnett11 barnett11 mentioned this pull request Oct 4, 2021
Closed
4 tasks
@waddella
Copy link
Contributor

waddella commented Oct 8, 2021

please remove the blank lines as those are not a table structure but rather formatting information and rtables does not implement it yet (it is on the backlog though). I will create an issue to remove all the insert_rrows.

waddella
waddella approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@waddella waddella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the changes as mentioned and then merge

R/aet02.R Outdated
@@ -48,6 +48,7 @@ aet02_1 <- function(adsl, adae,
lbl_AEBODSYS <- var_labels_for(adae, "AEBODSYS")
lbl_AEDECOD <- var_labels_for(adae, "AEDECOD")

adae$AEBODSYSn <- paste0("\n", adae$AEBODSYS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@BFalquet BFalquet merged commit ed6cd4c into main Oct 8, 2021
@BFalquet BFalquet deleted the 29_aet02-uat-feedback@main branch October 8, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waddella waddella waddella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AET02 UAT feedback
2 participants
@BFalquet @waddella