Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

218: fix bioc devel problems #219

Merged
merged 4 commits into from
Jan 18, 2024
Merged

218: fix bioc devel problems #219

merged 4 commits into from
Jan 18, 2024

Conversation

danielinteractive
Copy link
Collaborator

part of #218

Copy link
Contributor

github-actions bot commented Jan 12, 2024

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ------------------------
R/assertthat.R                19       1  94.74%   149
R/calc_cor.R                  25       0  100.00%
R/checkmate.R                  4       0  100.00%
R/connections.R              143     125  12.59%   27-161, 215-287, 356-381
R/differential.R             101       3  97.03%   190, 193, 196
R/dplyr_compatibility.R        3       1  66.67%   23
R/draw_barplot.R              34       0  100.00%
R/draw_boxplot.R              71       5  92.96%   81, 88-89, 106, 109
R/draw_heatmap.R              35       1  97.14%   71
R/draw_scatterplot.R          32       4  87.50%   73-74, 87, 93
R/GeneSpec-class.R            68       0  100.00%
R/graphs.R                   107       3  97.20%   107-109
R/HermesData-class.R          35       4  88.57%   134-137
R/HermesData-methods.R       194       0  100.00%
R/HermesData-validate.R       44       0  100.00%
R/join_cdisc.R                37       0  100.00%
R/normalization.R            100       2  98.00%   194, 223
R/pca_cor_samplevar.R         59       0  100.00%
R/pca.R                       28       0  100.00%
R/quality.R                   75       3  96.00%   109-112
R/top_genes.R                 51       0  100.00%
R/utils.R                     98       0  100.00%
TOTAL                       1363     152  88.85%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ad0fd06

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Unit Tests Summary

  1 files   23 suites   1m 4s ⏱️
273 tests 256 ✅ 17 💤 0 ❌
849 runs  827 ✅ 22 💤 0 ❌

Results for commit ad0fd06.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
differential 💚 $29.69$ $-1.25$ $0$ $0$ $0$ $0$

Results for commit c3cb59d

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BFalquet BFalquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like some pretty subtle changes. I see in the tests that the roxygene version is not matching perfectly and there seem to be a small issue in a vignette. Once these little technicalities are solved, it should be good to go.

@danielinteractive
Copy link
Collaborator Author

Thanks @BFalquet , hm strange, somehow the summarized_experiment object is not found anymore?

@danielinteractive danielinteractive merged commit 102d4ae into main Jan 18, 2024
24 of 25 checks passed
@danielinteractive danielinteractive deleted the 218_fix_bioc_devel branch January 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants