Skip to content

Commit

Permalink
news and style
Browse files Browse the repository at this point in the history
  • Loading branch information
Melkiades committed Jan 9, 2024
1 parent adb28ca commit 8e0bbc5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
18 changes: 10 additions & 8 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
## rlistings 0.2.7.9001
* Added relevant tests for pagination when key columns need to be repeated in each page and when they are all empty.
* Added relevant tests for new line characters' handling in footnotes and titles.

## rlistings 0.2.7
* Applied `styler` and resolved package lint. Changed default indentation from 4 spaces to 2.
* Fixed bug in `add_listing_col` when both a function and a format are specified.
* Added a vignette on referential footnotes workaround.
* Added a vignette on formatting columns.
* Added a vignette on pagination.
* Applied `styler` and resolved package lint. Changed default indentation from 4 spaces to 2.
* Fixed bug in `add_listing_col` when both a function and a format are specified.
* Added a vignette on referential footnotes workaround.
* Added a vignette on formatting columns.
* Added a vignette on pagination.

## rlistings 0.2.6
* Fixed bug in pagination preventing key column values to appear in paginated listings when `export_as_txt` was used.
* Added tests to cover for `export_as_txt` outputs.
* Integrated support for newline characters.
* Fixed bug in pagination preventing key column values to appear in paginated listings when `export_as_txt` was used.
* Added tests to cover for `export_as_txt` outputs.
* Integrated support for newline characters.

## rlistings 0.2.5
* Fixed bug in `as_listing` preventing custom formatting from being applied to key columns.
Expand Down
3 changes: 1 addition & 2 deletions tests/testthat/test-paginate_listing.R
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,12 @@ testthat::test_that("pagination repeats keycols in other pages", {
expect_warning(
as_listing(tibble("a" = rep("", 25), "b" = seq(25)), key_cols = "a") %>%
paginate_to_mpfs(lpp = 10)
)
)
)

expect_snapshot(
cat(toString(mf_pages[[3]]))
)

})

testthat::test_that("defunct is defunct", {
Expand Down

0 comments on commit 8e0bbc5

Please sign in to comment.