Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cran feedback #103

Merged
merged 3 commits into from Mar 17, 2023
Merged

Fix cran feedback #103

merged 3 commits into from Mar 17, 2023

Conversation

gmbecker
Copy link
Contributor

[skip vbump]

insights-engineering-bot
insights-engineering-bot approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@insights-engineering-bot insights-engineering-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -------------------------
R/listing_export.R          58       9  84.48%   97, 132, 143-154
R/paginate_listing.R       105       5  95.24%   94, 99, 103, 106, 109
R/rlistings_methods.R      118      12  89.83%   32, 47, 130-133, 220-226
R/rlistings.R              130      12  90.77%   294-297, 301-304, 332-335
TOTAL                      411      38  90.75%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 5fdff3e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited

Unit Tests Summary

  1 files    4 suites   33s ⏱️
17 tests 17 ✔️ 0 💤 0 ❌
54 runs  54 ✔️ 0 💤 0 ❌

Results for commit be80d18.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! :)

@gmbecker gmbecker merged commit 8a65c97 into main Mar 17, 2023
@gmbecker gmbecker deleted the fix_cran_feedback branch March 17, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@insights-engineering-bot insights-engineering-bot insights-engineering-bot approved these changes

@edelarua edelarua Awaiting requested review from edelarua edelarua is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmbecker @Melkiades @insights-engineering-bot