Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes after wrap_string refactoring #163

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Fixes after wrap_string refactoring #163

merged 6 commits into from
Oct 11, 2023

Conversation

Melkiades
Copy link
Contributor

No description provided.

@Melkiades Melkiades added bug Something isn't working sme labels Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Unit Tests Summary

  1 files    4 suites   4s ⏱️
29 tests 23 ✔️ 6 💤 0 ❌
74 runs  66 ✔️ 8 💤 0 ❌

Results for commit 24b409f.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades commented Oct 6, 2023
View reviewed changes
tests/testthat/_snaps/print.md
Comment on lines +34 to +37
AB12345 B: 4.5749910
- Placebo 1339464
CHN-1-
id-307
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now this is better honestly (the other things are the same

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      107      14  86.92%   39, 54, 58, 152-155, 158, 242-248
R/rlistings.R              159      20  87.42%   156-157, 160-161, 200-202, 366-369, 373-376, 405, 409-412
TOTAL                      313      35  88.82%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  -------
R/rlistings_methods.R       +6       0  +0.78%
TOTAL                       +6       0  +0.22%

Results for commit: 24b409f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

edelarua
edelarua approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Davide :)

@Melkiades Melkiades merged commit 67e329f into main Oct 11, 2023
24 checks passed
@Melkiades Melkiades deleted the 202_fix_trimming@main branch October 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

@insights-engineering-bot insights-engineering-bot Awaiting requested review from insights-engineering-bot

Assignees
No one assigned
Labels
bug Something isn't working sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Melkiades @edelarua