Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column formatting vignette #181

Merged
merged 8 commits into from Oct 26, 2023
Merged

Column formatting vignette #181

merged 8 commits into from Oct 26, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Oct 25, 2023 •
edited

Closes #178

Error in last example will be resolved by #180.

@edelarua edelarua added the sme label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 374-377, 381-384, 417-420
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 1e61532

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited

Unit Tests Summary

  1 files    4 suites   9s ⏱️
32 tests 25 ✔️ 7 💤 0 ❌
80 runs  71 ✔️ 9 💤 0 ❌

Results for commit 1e61532.

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!! Thanks Emily for this! :)

ayogasekaram
ayogasekaram approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well written @edelarua! I found it very clear and informative :)

vignettes/col_formatting.Rmd Outdated Show resolved Hide resolved
vignettes/col_formatting.Rmd Outdated Show resolved Hide resolved
vignettes/col_formatting.Rmd Outdated Show resolved Hide resolved
vignettes/col_formatting.Rmd Outdated Show resolved Hide resolved
@edelarua edelarua enabled auto-merge (squash) October 26, 2023 16:19
@edelarua edelarua merged commit 98e84ac into main Oct 26, 2023
23 checks passed
@edelarua edelarua deleted the 178_formatting_vignette@main branch October 26, 2023 16:20
@edelarua edelarua linked an issue Oct 26, 2023 that may be closed by this pull request
Vignette on column formatting #178
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@ayogasekaram ayogasekaram ayogasekaram approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vignette on column formatting
3 participants
@edelarua @Melkiades @ayogasekaram