261 truetype pag new #211
261 truetype pag new #211
Conversation
gmbecker
requested review from
edelarua,
Melkiades and
ayogasekaram
as code owners
|
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
| @@ -170,19 +174,15 @@ testthat::test_that("pagination: lpp and cpp correctly computed for margins", { | |||
| }) | |||
|
|
|||
| testthat::test_that("pagination works with col wrapping", { | |||
| lsting <- h_lsting_adae(disp_cols = c("USUBJID", "AESOC", "RACE")) | |||
| ## This test was predicated and enforcing the extra colgap bug in https://github.com/insightsengineering/formatters/issues/249 | |||
There was a problem hiding this comment.
I am not sure we can comment code in tests. Probably better to keep it and then change it in the colgap PR
There was a problem hiding this comment.
For reference: insightsengineering/formatters#249
There was a problem hiding this comment.
It doesn't pass which is why it is commented out, I had to fix the referenced formatters bug in order to get everything working. We can't keep it unless we specifically add the bug back into my PR which would be non-trivial (and silly to do)
There was a problem hiding this comment.
I can delete it entirely instead of leaving it there commented out if that is preferable
There was a problem hiding this comment.
Could you change it to test that the bug is not present? otherwise we can remove
There was a problem hiding this comment.
There is a test in the formatters PR for this, is that sufficient? (thats where the bug was and where the issue was filed)
corresponds to insightsengineering/formatters#270
Implements truetype support and updates rlistings for the new formatters version