Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps {rmarkdown} minimal version #212

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

Copy link
Contributor

github-actions bot commented May 16, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@averissimo averissimo marked this pull request as ready for review May 22, 2024 22:18
@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 22, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        29       5  82.76%   81-86
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              181      26  85.64%   159-162, 165-168, 176, 209-213, 385-388, 392-395, 424-427
TOTAL                      327      57  82.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d33475f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 22, 2024

Unit Tests Summary

  1 files   5 suites   10s ⏱️
 37 tests 29 ✅  8 💤 0 ❌
104 runs  91 ✅ 13 💤 0 ❌

Results for commit d33475f.

♻️ This comment has been updated with latest results.

@averissimo averissimo marked this pull request as draft May 23, 2024 04:14
@averissimo averissimo marked this pull request as ready for review June 11, 2024 07:16
@averissimo
Copy link
Contributor Author

{verdepcheck} Workflow passes all but release: https://github.com/insightsengineering/rlistings/actions/runs/9455953379

release is expected to fail as the required version of formatters is not on CRAN yet

@averissimo averissimo merged commit ef553d1 into main Jun 11, 2024
59 of 60 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch June 11, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants