cbind_rtables loses formats of individual tables that are combined

[danielinteractive]

library(rtables)

tab1 <- rtable(
  header = "a",
  rrow("one", 1.1111111, format = "xx.x")
)
tab2 <- rtable(
  header = "b",
  rrow("one", 2.2222222, format = "xx.xxxx")
)

wrong_format <- cbind_rtables(tab1, tab2)

It seems like only the format of the left table is used, so that the formats of the right table are overwritten wrongly by the left table formats. We would want the formats to stay correct per column/sub table. (same session info here as in #111)

[gmbecker]

If you want the formats to stay on a per cell basis they should be on the cell level. A row can only ever have one format associated with it, by design. That said there is currently a big where what should work, ie ```r tab1 <- rtable( header = "a", rrow("one", rcell(1.1111111, format = "xx.x")) ) tab2 <- rtable( header = "b", rrow("one", rcell(2.2222222, format = "xx.xxxx")) ) cbind_rtables(tab1, tab2) ``` also doesn't work because the cell formats are being put on the rows, but I will get that fixed.

…

On Wed, Oct 21, 2020 at 3:32 AM Daniel Sabanes Bove < ***@***.***> wrote: Assigned #112 <#112> to @gmbecker <https://github.com/gmbecker>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG53MJNRWLPVENDML3BCTDSL22DJANCNFSM4SZSTXPA> .

[danielinteractive]

Thanks @gmbecker . Will be great to have this fixed.

[gmbecker]

This is fixed in 24a972c but that unearthed a bug, which is now fixed in 13f32f1

Make sure you use version 0.3.2.17.9035, from the latter commit, to get both this and the unearthed bug fixed.

Thanks for the report.

[danielinteractive]

Thanks a lot @gmbecker !