disable total column if not in parallel #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 33 suites 2s ⏱️ Results for commit 5c1d9f7. ♻️ This comment has been updated with latest results. |
2 tasks
Melkiades
approved these changes
Mar 1, 2024
You tell me :) |
pawelru
added a commit
to insightsengineering/tlg-catalog
that referenced
this pull request
Mar 1, 2024
Keeping it as a draft for the time being. There are a few PRs that needs to be merged to make it pass: - [x] insightsengineering/teal.data#301 - [x] insightsengineering/teal.modules.clinical#1087 Locally, when using above fixes, I get the whole catalog rendered. This does not mean that stable will be working - that needs additional work.
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLGCatalog
EGT01filed because of this.Talked with @Melkiades and it seems that
summarize_colvars()does not play nicely together withadd_overall_col()before. Hence putted this in the if condition.You can test it as follows:
pkgload::dev_example("tm_t_summary_by")Currently on main it's (gracefully) failing. After this fix, all patients flag is silently ignored.