Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

804 deprecation notes in ggplot2 #810

Merged
merged 4 commits into from
Aug 3, 2023
Merged

804 deprecation notes in ggplot2 #810

merged 4 commits into from
Aug 3, 2023

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Aug 2, 2023

Fixes #804

@chlebowa chlebowa added the core label Aug 2, 2023
@chlebowa chlebowa self-assigned this Aug 2, 2023
@chlebowa chlebowa requested a review from a team August 2, 2023 15:32
@chlebowa chlebowa enabled auto-merge (squash) August 2, 2023 15:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit dfe39f9.

♻️ This comment has been updated with latest results.

@gogonzo
Copy link
Contributor

gogonzo commented Aug 2, 2023 •
edited
Loading

I think it requires to bump up ggplot2 in DESCRIPTION
Changelog of 3.4.0 says:

Breaking changes

  • A linewidth aesthetic has been introduced and supersedes the size aesthetic for scaling the width of lines in line based geoms. size will remain functioning but deprecated for these geoms and it is recommended to update all code to reflect the new aesthetic. For geoms that have both point sizing and linewidth sizing (geom_pointrange() and geom_sf) size now only refers to sizing of points which can leads to a visual change in old code (@thomasp85, #3672)

@chlebowa
Copy link
Contributor Author

chlebowa commented Aug 3, 2023

Indeed.

kartikeyakirar
kartikeyakirar approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chlebowa chlebowa merged commit 69f6365 into main Aug 3, 2023
24 checks passed
@chlebowa chlebowa deleted the 804_ggplot2_deprecation@main branch August 3, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@chlebowa chlebowa

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: depracation notes for ggplot2 usage in tm_g_pp_therapy
3 participants
@chlebowa @gogonzo @kartikeyakirar