Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-cdisc examples to the modules #29

Closed
12 tasks done
cicdguy opened this issue Aug 5, 2021 · 4 comments · Fixed by #651
Closed
12 tasks done

Add non-cdisc examples to the modules #29

cicdguy opened this issue Aug 5, 2021 · 4 comments · Fixed by #651
Assignees
Labels
core documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@cicdguy
Copy link
Contributor

cicdguy commented Aug 5, 2021

Modules without a non-cdisc example:

Provenance:

Creator: kpagacz
@cicdguy cicdguy added core documentation Improvements or additions to documentation SP5 labels Aug 5, 2021
@pawelru pawelru removed the SP5 label Mar 23, 2022
@donyunardi donyunardi added the good first issue Good for newcomers label Sep 14, 2023
@chlebowa chlebowa self-assigned this Feb 19, 2024
@chlebowa
Copy link
Contributor

Do we want to add non-CDISC examples or replace CDISC examples with ones with normal data?

@m7pr
Copy link
Contributor

m7pr commented Feb 20, 2024

Maybe we can replace all examples with normal data and remove evertyhing we have under data/ folder https://github.com/insightsengineering/teal.modules.general/tree/main/data is they are not included in the vignettes?

@donyunardi
Copy link
Contributor

donyunardi commented Feb 20, 2024

Do we want to add non-CDISC examples or replace CDISC examples with ones with normal data?

We want to add non-cdisc examples, in addition of the cdisc example one.

Maybe we can replace all examples with normal data and remove evertyhing we have under data/ folder https://github.com/insightsengineering/teal.modules.general/tree/main/data is they are not included in the vignettes?

We're not removing cdisc examples from our docs, so will need to keep everything under data/ folder.

@chlebowa
Copy link
Contributor

Do we want to add non-CDISC examples or replace CDISC examples with ones with normal data?

We want to add non-cdisc examples, in addition of the cdisc example one.

Very well, the PR is ready for review. The bugs mentioned above remain to be fixed and it would be good to solve them before release but are not hard blockers.

chlebowa added a commit that referenced this issue Feb 22, 2024
Closes #29 

Added general data examples to modules.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@donyunardi donyunardi mentioned this issue Feb 27, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants