Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple scda #214

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Decouple scda #214

merged 3 commits into from
Jul 6, 2023

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Jun 30, 2023 •
edited
Loading

@gogonzo gogonzo added the core label Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Merged
@gogonzo gogonzo changed the title remove scda Decouple scda Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             247     247  0.00%    108-388
R/tm_g_ae_sub.R               316     316  0.00%    56-408
R/tm_g_butterfly.R            385     385  0.00%    135-560
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       296     296  0.00%    62-396
R/tm_g_heat_bygrade.R         318     318  0.00%    161-514
R/tm_g_patient_profile.R      708     708  0.00%    197-970
R/tm_g_spiderplot.R           321     321  0.00%    103-469
R/tm_g_swimlane.R             375     375  0.00%    129-561
R/tm_g_waterfall.R            422     422  0.00%    113-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         1       1  0.00%    2
TOTAL                        3472    3467  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7f33743

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   0s ⏱️
  4 tests   4 ✔️ 0 💤 0 ❌
13 runs  13 ✔️ 0 💤 0 ❌

Results for commit eb019fa.

♻️ This comment has been updated with latest results.

chlebowa
chlebowa approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind using data sets defined in osprey as this package Depends on osprey, however I do recall it being said that all packages should contain their own data sets for tests. If that is not a crucial requirement, this is good to go.

@gogonzo gogonzo merged commit b6de623 into main Jul 6, 2023
27 checks passed
@gogonzo gogonzo deleted the decouple_scda@main branch July 6, 2023 08:04
gogonzo added a commit to insightsengineering/scda that referenced this pull request Jul 6, 2023
@gogonzo @kartikeyakirar
Decouple scda (#125)
123963c 
- [ ] teal insightsengineering/teal#858
- [ ] teal.widgets
- [ ] osprey insightsengineering/osprey#121
- [ ] teal.osprey
insightsengineering/teal.osprey#214
- [ ] teal.transform
insightsengineering/teal.transform#139

---------

Signed-off-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
gogonzo added a commit to insightsengineering/scda.2022 that referenced this pull request Jul 6, 2023
@gogonzo
Decouple scda (#123)
172d42e 
- [ ] teal insightsengineering/teal#858
- [ ] teal.widgets
- [ ] osprey insightsengineering/osprey#121
- [ ] teal.osprey
insightsengineering/teal.osprey#214
- [ ] teal.transform
insightsengineering/teal.transform#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlebowa chlebowa chlebowa approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple scda
2 participants
@gogonzo @chlebowa