Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Counts of the filter should be based on filtered-data #131

Closed
Tracked by #81
gogonzo opened this issue Nov 23, 2022 · 0 comments · Fixed by #164
Closed
Tracked by #81

[Feature Request]: Counts of the filter should be based on filtered-data #131

gogonzo opened this issue Nov 23, 2022 · 0 comments · Fixed by #164
Assignees
Labels
core enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Nov 23, 2022

Feature description

Histogram in RangeFilterState, or bars in the ChoicesFilterState, etc. base now on unfiltered data. Which means That if somebody adds (for example) SEX filter it always displays the same numbers of observations for M, F, U and NA. The point is to rerender these values based on the state of the filtered-data. This will help users to follow what exactly remains after applying other filters.

image


Tip: this will require passing filtered-data (reactive) to the srv_filter_panel and pass it down to the place where FilterState is initialized (FilteredData$srv_filter_panel > FilteredDataset[i]$srv_add_filter_state > FilterStates[i]$srv_add_filter_state > init_filter_state). In the image below I present how srv modules are called withing filter-panel classes. FilteredData$filter_panel_srv calls three modules which can be seen in the filter-panel as "Summary", "Active filters", "Add filter". In the beginning active filters (srv) are empty and new filters can be added through srv_add. When new filter is selected then a new FIlterState is created and pushed to the ReactiveQueue. FIlterStates$srv detects that a new FilterState has been added and calls insert_filter_state_ui which calls FilterState$ui and FilterState$srv modules.

image

@gogonzo gogonzo added the enhancement New feature or request label Nov 23, 2022
@gogonzo gogonzo added this to the Module specific filter-panel milestone Nov 23, 2022
@gogonzo gogonzo added the core label Nov 23, 2022
@gogonzo gogonzo changed the title [Feature Request]: Counts of the filter should be based on filtered-data not unfiltered [Feature Request]: Counts of the filter should be based on filtered-data Jan 12, 2023
@gogonzo gogonzo changed the title [Feature Request]: Counts of the filter should be based on filtered-data not unfiltered [Feature Request]: Counts of the filter should be based on filtered-data Jan 12, 2023
@nikolas-burkoff nikolas-burkoff self-assigned this Jan 13, 2023
gogonzo added a commit that referenced this issue Jan 19, 2023
Closes #131 and closes #142 and closes #161 and closes #162


Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com>
@gogonzo gogonzo closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants