Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickerInput labels (counts ) are too reactive #167

Closed
Tracked by #165
gogonzo opened this issue Jan 19, 2023 · 1 comment
Closed
Tracked by #165

pickerInput labels (counts ) are too reactive #167

gogonzo opened this issue Jan 19, 2023 · 1 comment
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Jan 19, 2023

Counts of the filter are too reactive. Selecting values instantly trigger re render of the inputs. In case of the pickerInput one is not able to select multiple values because click instantly impacts the ui-input.

Mozilla.Firefox.2023-01-17.09-28-34.mp4

We need to find the non-invasive way to update the counts which won't retrigger reactive events. Also pickerInput selection should be applied only when picker is closed dreamRs/shinyWidgets#392

@gogonzo gogonzo added the core label Jan 19, 2023
@gogonzo gogonzo self-assigned this Jan 20, 2023
@gogonzo gogonzo removed their assignment Jan 27, 2023
@gogonzo gogonzo changed the title Counts of the labels are too reactive pickerInput labels (counts ) are too reactive Jan 27, 2023
@gogonzo gogonzo added this to the Module specific filter-panel milestone Jan 27, 2023
@donyunardi
Copy link
Contributor

donyunardi commented Feb 9, 2023

Could be related with #173 and #174
Per our discussion, the acceptance criteria is to decouple the filter counts/label from the input so we can separate the two activities.

@gogonzo gogonzo self-assigned this Feb 14, 2023
gogonzo added a commit that referenced this issue Feb 22, 2023
closes #173 #174 #167 

Making reactive filter counts triggered only if the filter is visible

Co-authored-by: Andrew Bates <andrew.bates@atorusresearch.com>
@gogonzo gogonzo closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants