Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetics of range selector and UX review #320

Closed
Tracked by #27
lcd2yyz opened this issue Jun 3, 2023 · 4 comments
Closed
Tracked by #27

Aesthetics of range selector and UX review #320

lcd2yyz opened this issue Jun 3, 2023 · 4 comments
Labels
core enhancement New feature or request

Comments

@lcd2yyz
Copy link

lcd2yyz commented Jun 3, 2023

If we decides to go with plotly range selector #289, few aesthetics needs to reviewed together with the new filter panel UX review insightsengineering/nestdevs-tasks#27

  • Look/feel of histogram plot - height, binning, size
  • Use the same two-tone colors for the categorical count horizontal bar char (dark vs light colored)? Currently the histogram is showing color vs grey
  • Spacing/margin around the plot and range selector UI

To be refined later..

@chlebowa
Copy link
Contributor

chlebowa commented Jun 5, 2023

  • Use the same two-tone colors for the categorical count horizontal bar char (dark vs light colored)? Currently the histogram is showing color vs grey

Please explain, do you want to use the histogram colors for the count bars or use the same color as the count bars for the histogram?

@chlebowa
Copy link
Contributor

chlebowa commented Jun 5, 2023

More issues:

  • refine how RangeFilterState$content_summary() represents the selected numbers

Where to start:

  • modify plot size in the plotlyOutput call
  • modify plot borders in the css file (using private$plot_layout will result in the lines sticking out further outside the plot area)
  • modify plot colors in private$plot_data and private$plot_filtered
  • modify bin number in private$plot_data

@lcd2yyz
Copy link
Author

lcd2yyz commented Jun 6, 2023

  • Use the same two-tone colors for the categorical count horizontal bar char (dark vs light colored)? Currently the histogram is showing color vs grey

Please explain, do you want to use the histogram colors for the count bars or use the same color as the count bars for the histogram?

The latter: use same color as the count bars for the histogram.
But this is just my preference, I would definite like to get a UX designer at some point.

@gogonzo
Copy link
Contributor

gogonzo commented May 28, 2024

addressed

@gogonzo gogonzo closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants