New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
183 choicefs improve init #194
183 choicefs improve init #194
Conversation
Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change x_reactive
to have no defaults in init. Please fix the assert to not let x_reactive
to be NULL
, it has to be a reactive.
Please fix the get_filtered_counts()
call mentioned below.
Besides, it's looking good
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com> Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com> Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
}) | ||
|
||
testthat::test_that("The constructor reactive as x_reactive", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testthat::test_that("The constructor accepts only reactive input for x_reactive", {
Pull Request
Fixes #183