Update vignettes #380

gogonzo · 2023-07-11T10:24:50Z

closes #52

…nel_refactor@main

align images

github-actions · 2023-07-11T10:33:43Z

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R              8       0  100.00%
R/choices_labeled.R              49      14  71.43%   22, 33, 38, 48-53, 65, 69-73
R/count_labels.R                 98       0  100.00%
R/filter_panel_api.R             37       2  94.59%   89, 101
R/FilteredData-utils.R          117      17  85.47%   103-108, 201, 223-232
R/FilteredData.R                574     222  61.32%   100-103, 477-485, 568-577, 599, 620-661, 679-682, 698, 739-772, 787-789, 793-799, 825-854, 876-878, 882-884, 887-898, 902-911, 913-939, 957-1027, 1069, 1092-1110
R/FilteredDataset-utils.R        20       1  95.00%   133
R/FilteredDataset.R             179      67  62.57%   50, 146, 195-201, 229-286, 326-328
R/FilteredDatasetDefault.R      121       9  92.56%   69, 131, 141, 145, 227-231
R/FilteredDatasetMAE.R          134      37  72.39%   27, 113-118, 157-162, 166-167, 187-209
R/FilterPanelAPI.R               10       0  100.00%
R/FilterState-utils.R           133       1  99.25%   370
R/FilterState.R                 291      46  84.19%   88, 210, 280, 324, 617-642, 653-672, 707-713, 722-728
R/FilterStateChoices.R          358     122  65.92%   291-294, 306, 334-340, 365, 389-396, 400-417, 446, 461-472, 484-492, 496-525, 546-549, 552-555, 566-587, 600-601, 611-615, 617-621
R/FilterStateDate.R             229     141  38.43%   216-222, 235, 285-446
R/FilterStateDatettime.R        331     218  34.14%   253-259, 273, 323-567
R/FilterStateEmpty.R             63      41  34.92%   82, 92-97, 111, 125-176
R/FilterStateExpr.R              61      48  21.31%   138-231
R/FilterStateLogical.R          216     163  24.54%   127, 150, 206-212, 220, 223-421
R/FilterStateRange.R            435     131  69.89%   251, 348-354, 362, 385, 513-517, 520-530, 533, 545-551, 562-574, 578-588, 592-594, 608-635, 650-654, 656-660, 665-669, 671-675, 692-709, 744-749, 759-761
R/FilterStates-utils.R           70       9  87.14%   102, 121, 179-185, 207, 234
R/FilterStates.R                360      30  91.67%   76-80, 189, 317-326, 413-416, 459, 544-548, 593, 705-708
R/FilterStatesDF.R                5       0  100.00%
R/FilterStatesMAE.R              10       1  90.00%   39
R/FilterStatesMatrix.R            3       0  100.00%
R/FilterStatesSE.R              211     157  25.59%   34, 69-71, 81-83, 107-114, 122-129, 152-300
R/include_css_js.R                5       5  0.00%    12-16
R/teal_slice-store.R              7       7  0.00%    28-57
R/teal_slice.R                   98       2  97.96%   132, 194
R/teal_slices.R                 133       1  99.25%   194
R/test_utils.R                   21       0  100.00%
R/utils.R                        49       2  95.92%   101-102
R/variable_types.R               48      33  31.25%   41-46, 56, 69-104
R/zzz.R                          15      15  0.00%    3-46
TOTAL                          4499    1542  65.73%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/calls_combine_by.R             +1       0  +100.00%
R/count_labels.R                +98       0  +100.00%
R/filter_panel_api.R            +37      +2  +94.59%
R/FilteredData-utils.R          +19     -26  +29.35%
R/FilteredData.R                +69     -45  +14.20%
R/FilteredDataset-utils.R       +20      +1  +95.00%
R/FilteredDataset.R              -9     -10  +3.53%
R/FilteredDatasetDefault.R      +15      +1  +0.11%
R/FilteredDatasetMAE.R          -74     -22  +0.75%
R/FilterPanelAPI.R              -13      -8  +34.78%
R/FilterState-utils.R           -22     -14  +8.93%
R/FilterState.R                 +64     -42  +22.96%
R/FilterStateChoices.R         +189     +26  +22.73%
R/FilterStateDate.R             +64     +33  +3.88%
R/FilterStateDatettime.R        +93     +52  +3.89%
R/FilterStateEmpty.R            +22     +25  -26.05%
R/FilterStateExpr.R             +61     +48  +21.31%
R/FilterStateLogical.R          +78     +84  -18.22%
R/FilterStateRange.R           +210      +2  +27.22%
R/FilterStates-utils.R           +2      +4  -5.50%
R/FilterStates.R               +142     -63  +34.33%
R/FilterStatesDF.R             -225     -29  +12.61%
R/FilterStatesMAE.R            -211    -105  +37.96%
R/FilterStatesMatrix.R         -214    -108  +49.77%
R/FilterStatesSE.R             -198     -44  -25.26%
R/teal_slice-store.R             +7      +7  +100.00%
R/teal_slice.R                  +98      +2  +97.96%
R/teal_slices.R                +133      +1  +99.25%
R/test_utils.R                  +21       0  +100.00%
R/utils.R                       +10       0  +1.05%
R/zzz.R                          +9      +9  +100.00%
TOTAL                          +496    -219  +8.73%

Results for commit: ddaeccc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2023-07-11T10:34:20Z

Unit Tests Summary

    1 files   29 suites 29s ⏱️
368 tests 366 ✔️ 0 💤 2 ❌
813 runs 811 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit ad8c770.

♻️ This comment has been updated with latest results.

…nel_refactor@main

vignettes/teal-slice-classes.Rmd

…insightsengineering/teal.slice into 52_vignettes@filter_panel_refactor@main # Conflicts: # vignettes/teal-slice-classes.Rmd # vignettes/teal-slice.Rmd

…hub.com/insightsengineering/teal.slice into 52_vignettes@filter_panel_refactor@main

gogonzo · 2023-07-14T12:44:49Z

R/FilterStateChoices.R

-                  "Any additional choices made will be disregarded."
-                ))
+            # update should be based on a change of counts only
+            shiny::isolate({


@chlebowa @m7pr I made this change because labels should change only when the reactive filtered data got changed

R/FilterStateChoices.R

gogonzo added 3 commits July 10, 2023 12:50

start

0d9195e

Merge branch 'filter_panel_refactor@main' into 52_vignettes@filter_pa…

9233d82

…nel_refactor@main

update vignettes

b49a660

align images

gogonzo added the core label Jul 11, 2023

gogonzo linked an issue Jul 11, 2023 that may be closed by this pull request

Update vignette after changes in the FilteredData #52

Closed

modify vignette for developers

9dea67c

chlebowa self-assigned this Jul 11, 2023

gogonzo added 2 commits July 13, 2023 09:15

Merge branch 'filter_panel_refactor@main' into 52_vignettes@filter_pa…

a1b84f3

…nel_refactor@main

fix images

5137552

chlebowa reviewed Jul 13, 2023

View reviewed changes

vignettes/teal-slice-classes.Rmd Outdated Show resolved Hide resolved

chlebowa reviewed Jul 13, 2023

View reviewed changes

vignettes/teal-slice-classes.Rmd Outdated Show resolved Hide resolved

gogonzo and others added 17 commits July 13, 2023 18:04

Fix

5efd67f

typo

c69f2f2

modify teal-slice vignette

a5ce763

modify teal-slice-classes vignette

89f7005

minor improvements to teal_slice(s) documentation

a2610f5

Merge branch '52_vignettes@filter_panel_refactor@main' of github.com:…

98e326d

…insightsengineering/teal.slice into 52_vignettes@filter_panel_refactor@main # Conflicts: # vignettes/teal-slice-classes.Rmd # vignettes/teal-slice.Rmd

fix MAE issue

8979111

[skip actions] Roxygen Man Pages Auto Update

a6f1556

typo

6c15c19

typo

8b727ba

typo

877326a

reduce complexity in the text by trimming sentences to single-sentences

122a232

behaviors -> any behaviors

e75374f

simplify text by splitting it into multiple single sentences

10d17da

classes should be plural

e4d8873

functions or methods?

c3d2f1e

backticks around shiny

52cba94

m7pr and others added 8 commits July 14, 2023 14:27

missing dot

329927e

typo

c4289fb

is calls -> is called

6fb23da

typo

2d4bd8c

fix hyperreactivity of optionalSelectInput

8e3738c

FilterState subclasses

87a939f

teal_slice is S3

e4cd3c7

Merge branch '52_vignettes@filter_panel_refactor@main' of https://git…

50d2177

…hub.com/insightsengineering/teal.slice into 52_vignettes@filter_panel_refactor@main

gogonzo commented Jul 14, 2023

View reviewed changes

typo

fb32a0c

gogonzo commented Jul 14, 2023

View reviewed changes

R/FilterStateChoices.R Show resolved Hide resolved

Aleksander Chlebowski and others added 3 commits July 14, 2023 15:46

clean up

92bac59

spelling

1cb7e15

Champion @chlebowa

ad8c770

chlebowa approved these changes Jul 14, 2023

View reviewed changes

gogonzo merged commit a3fb7e8 into filter_panel_refactor@main Jul 14, 2023
21 of 23 checks passed

gogonzo deleted the 52_vignettes@filter_panel_refactor@main branch July 14, 2023 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vignettes #380

Update vignettes #380

gogonzo commented Jul 11, 2023

github-actions bot commented Jul 11, 2023 •

edited

github-actions bot commented Jul 11, 2023 •

edited

gogonzo Jul 14, 2023

Update vignettes #380

Update vignettes #380

Conversation

gogonzo commented Jul 11, 2023

github-actions bot commented Jul 11, 2023 • edited

Code Coverage Summary

Diff against main

github-actions bot commented Jul 11, 2023 • edited

Unit Tests Summary

gogonzo Jul 14, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 11, 2023 •

edited

github-actions bot commented Jul 11, 2023 •

edited