Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Differentiating "not applied" and "not applicable" in filter manager matrix #866

Closed
3 tasks done
lcd2yyz opened this issue Jul 21, 2023 · 1 comment
Closed
3 tasks done
Labels
enhancement New feature or request

Comments

@lcd2yyz
Copy link
Contributor

lcd2yyz commented Jul 21, 2023

Feature description

Consider the following code

default_filters <- teal::teal_slices(
  teal_slice("iris", "Sepal.Length", sel = c(5.5, 6.5), fixed = FALSE),
  teal_slice("iris", "Species", anchored = TRUE),
  teal_slice("mtcars", "mpg"),
  module_specific = TRUE,
  mapping = list(
    table = c("iris Sepal.Length"),
    funny = c("iris Species"),
    global_filters = "mtcars mpg"
  )
)

app <- init(
  data = teal_data(
    dataset("iris", iris),
    dataset("mtcars", mtcars)
  ),
  modules = modules(
    tm_data_table(
      "table",
      variables_selected = list(),
      dt_args = list()
    ),
    funny_module("funny", datanames = "iris"),
    funny_module("funny2", datanames = "mtcars")
  ),
  filter = default_filters
)
  • mtcars dataset is not used in funny module
  • iris dataset is not used in funny2 module
    image

Filters should be considered "not applicable" if the module is not using the dataset that the filter variable is from. Thus instead of showing X mark, should display an icon that would convey meaning of "NA", for example https://www.compart.com/en/unicode/U+2796

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@lcd2yyz lcd2yyz added the enhancement New feature or request label Jul 21, 2023
@chlebowa
Copy link
Contributor

duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants