Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify mapping_matrix in filter manager module #867

Closed
chlebowa opened this issue Jul 5, 2023 · 0 comments · Fixed by #879
Closed

modify mapping_matrix in filter manager module #867

chlebowa opened this issue Jul 5, 2023 · 0 comments · Fixed by #879
Assignees
@chlebowa
Labels
core enhancement New feature or request good first issue Good for newcomers

Comments

@chlebowa
Copy link
Contributor

chlebowa commented Jul 5, 2023 •
edited

Blocked by insightsengineering/teal.slice#298

The mapping_matrix displays the mapping of filters to modules as a logical matrix (actually a data.frame).
image
It only says whether a filter is applied to a module. However, some filters are not available for all modules.

In case a filter CANNOT be applied to a module, the mapping matrix should display NA.

Bear in mind the mapping matrix is passed to the snapshot manager module, where it is converted to the mapping attribute of teal_slices by the mapping_to_matrix function (or something similar) and that process does not foresee NAs.
@chlebowa chlebowa added enhancement New feature or request core blocked good first issue Good for newcomers labels Jul 5, 2023
@chlebowa chlebowa mentioned this issue Jul 21, 2023
Closed
3 tasks
@chlebowa chlebowa transferred this issue from insightsengineering/teal.slice Jul 21, 2023
@chlebowa chlebowa removed the blocked label Jul 21, 2023
This was referenced Jul 30, 2023
Merged
Merged
@chlebowa chlebowa self-assigned this Jul 30, 2023
chlebowa added a commit to insightsengineering/teal.slice that referenced this issue Aug 1, 2023
@chlebowa
867 modify mapping matrix (#408)
91359a9 
Related to [this
issue](insightsengineering/teal#867).

`FilteredData` receives a new public method,
`$get_available_teal_slices` that returns the contents of the private
field `private$available_teal_slices`.
chlebowa added a commit that referenced this issue Aug 1, 2023
@chlebowa
867 modify mapping matrix (#879)
036eafa 
Fixes #867 
Fixes #878 

The mapping matrix is modified to display filters that cannot be applied
to a particular module as NA.

In `matrix_to_mapping` filters that are NA are treated as TRUE because
global filters may not apply to some modules.

Requires a new public method in `FilteredData`, introduced
[here](insightsengineering/teal.slice#408).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlebowa chlebowa

Labels
core enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

867 modify mapping matrix insightsengineering/teal
1 participant
@chlebowa