-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix decorate grob vp widths for titles and footers when right margin is present #1245
Conversation
CLA Assistant Lite bot ✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Unit Tests Summary 1 files 83 suites 1m 4s ⏱️ Results for commit edafc7a. ♻️ This comment has been updated with latest results. |
…sightsengineering/tern into 1240_fix_decorate_grob_vp_widths@main
Code Coverage Summary
Diff against main
Results for commit: edafc7a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Can someone please help me review this? @ayogasekaram @edelarua Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Davide!!
@pawelru rstudio does not work superwell with viewport as far as I could see. Everything works for base R on my machine. Have not tried VS but my output in rstudio is identical to vs |
You are right. Base R should be the main testing environment. Tested it there and it's good. Also tested your feature branch versus the main and I can notice that the issue is fixed now. I think it's good to go. |
It is a valid point; I could not think of a proper test for it. I can use the width of the viewport as a test. It is what needs to be respected for the wrapping at the end. Btw the wrapping core is not keeping spaces and manual \n as far as I can see. We might want to use the one I wrote for {formatters} that keeps those. What do you think? |
This I don't know to be honest. I'm afraid that I'm not that deep in this to make a statement. I'm going to approve as I can see that the issue had been resolved. Please make a call about the test. If it can't be done then I guess we need to live with that. |
I added and closed an issue to track down my research. Testing for this issue can be a bit difficult considering the inconsistencies between different viewport page sizes' conversions |
#1240