-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create analyze_num_patients
and correct ae* tables
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ightsengineering/tern into 748_create_analyze_num_patients@main
This was referenced Dec 21, 2022
…ightsengineering/tern into 748_create_analyze_num_patients@main
ayogasekaram
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @Melkiades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #748
Note: this was done primarily for pagination issues (new tests target this precisely, see
test_summarize_num_patients
). Concurrently, also sorting is tested.This PR must be followed by a couple of fixes and enhancements, listed here:
# add_overall_col(label = "A+B") %>% # why this does not work
in new test insidetest_summarize_num_patients.R
. not really a problem, wrong position of itscore_occurrences
or add another score function that selects the columns (likemy_score_occurences
does at the moment). Modify and updatescore_occurrences
so to have proper tests with different underlyingrtables
layouts to be sorted #785 (this was already there with the namescore_occurences_cols
, but the referred PR made other fixes along the way).test_score_occurences.R
uses summarize in the "broken-pagination" way should be fixed along with the previous point.summarize_occurrences_by_grade
has the same problem assummarize_num_patients
and needs to be fixed in a separate PR to fixaet04
. Fixsummarize_occurrences_by_grade
to work with pagination #783The last point involves (currently) the following templates:
All of the above-mentioned have in some way or another a possibly breaking pagination due to using
summarize_row_groups
before the split so that it would end wrongfully on all the pages.@ayogasekaram fyi this PR contains also an enhancement for the function
to_string_matrix
with a handy way to copy-paste the result matrix (this is intended for a more general and practical fix of #784 and future uses.