Fixed population of the <html> lang attribute default for quick comma…

…nds6
insin · Mar 24, 2020 · db1b597 · db1b597
1 parent 3163aad
commit db1b597
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -7,6 +7,10 @@
   - Chunk sorting was removed, but it seems to work as before for the ordering of the JavaScript files generated by nwb's build.
   - The plugin nwb uses to inline the webpack runtime chunk was rewritten to use v4's new hooks.
 
+## Fixed
+
+- The `lang` attribute on `<html>` wasn't getting set to the default `'en'` when using the `nwb react`, `nwb preact` and `nwb inferno` quick development commands.
+
 ## Dependencies
 
 - @babel/plugin-transform-react-jsx: v7.9.1 → [v7.9.4](https://github.com/babel/babel/releases/tag/v7.9.4)

diff --git a/src/quickCommands.js b/src/quickCommands.js
@@ -93,6 +93,7 @@ export function createBuildConfig(args: Object, options: QuickConfigOptions) {
     },
     plugins: {
       html: {
+        lang: 'en',
         mountId,
         title: args.title || defaultTitle,
       },
@@ -154,6 +155,7 @@ export function createServeConfig(args: Object, options: QuickConfigOptions) {
     },
     plugins: {
       html: {
+        lang: 'en',
         mountId,
         title: args.title || defaultTitle,
       },