Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always run tools in the user's current working directory #41

Closed
insin opened this issue Jan 6, 2016 · 0 comments
Closed

Always run tools in the user's current working directory #41

insin opened this issue Jan 6, 2016 · 0 comments
Labels
dependencies

Comments

@insin
Copy link
Owner

insin commented Jan 6, 2016

Currently, Karma tests are run in the context of nwb's install directory.

We should be able to import all plugins managed by nwb instead of using strings and having Karma import them, so changing the working directory shouldn't be necessary any more.

Benefits:

  • Less surprising for the user
  • Makes additional config easier - additional plugins could be specified as shorthand strings, as Babel should now be able to resolve and require plugins installed in the user's own project
@insin insin modified the milestone: 0.8 Jan 8, 2016
@insin insin mentioned this issue Jan 8, 2016
Closed
2 tasks
@insin insin modified the milestone: 0.8 Jan 8, 2016
@insin insin mentioned this issue Jan 8, 2016
Closed
8 tasks
insin added a commit that referenced this issue Jan 17, 2016
@insin
More cleanup related to always running in the initial working directory
b7893f0 
- Run Babel module builds in the current working directory
- Replace use of path.join(cwd, ...) with path.resolve(...)
- Remove the cwd parameter from places it's no longer needed

#41
@insin insin closed this as completed in 0ad7eeb Feb 25, 2016
@geowarin geowarin mentioned this issue Feb 25, 2016
Closed
@qyl2021 qyl2021 mentioned this issue Jan 10, 2023
Open
@xtiko14 xtiko14 mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@insin